roidrole / A-Dark-Mode

Reskins minecraft and some mods to a dark mode
0 stars 0 forks source link

🌳`E2E-E` support #7

Open Krutoy242 opened 3 weeks ago

Krutoy242 commented 3 weeks ago

Hello there, this is E2E-E dev! I'm very excited about this dark mode and explicit E2E-E support. I want to make this texture pack official and shipped with modpack, or at least recommend it on modpack main page.

There is several incompats and I will post them in this thread when found.

Some for now:

roidrole commented 2 weeks ago

First, I'm glad for your interest in this project! Tackling this incompat list, I found a few out of my reach :

If these limitations are deal-breakers, I can, at your request, remove the compatibility with E2EE claim

I'll add that I don't feel the need to remake the HarvestCraft's GUIs as they don't follow vanilla styles and are colored (as opposed to flat white GUIs). That decision is up for debate

On another note, all other support (and the improvement of JECalc) have been added to 1.8.0 release (pending approval)

Krutoy242 commented 2 weeks ago

If these limitations are deal-breakers, I can, at your request, remove the compatibility with E2EE claim

No, if you will maintain project and fix non-colored GUIs it will be awesome. Also, technically, colores of programmically-drawn interfaces could be changed via CraftTweaker.

roidrole commented 2 weeks ago

Also, technically, colores of programmically-drawn interfaces could be changed via CraftTweaker.

I'll probably investigate that possibility when I have more time, but it might take a while. Do you know where/if i can find docs for that?

Krutoy242 commented 2 weeks ago

Docs for the Crafttweaker Mixins? Its very recent and complicated thing, i could only give an example of code E2EE using https://github.com/Krutoy242/Enigmatica2Expert-Extended/pull/407

W4BEPMA commented 2 weeks ago

изображение integrated terminals item storage tab

W4BEPMA commented 2 weeks ago

изображение crafting tab

Krutoy242 commented 2 weeks ago

Found new ones:

Krutoy242 commented 2 weeks ago
Krutoy242 commented 2 weeks ago
Krutoy242 commented 2 weeks ago
Krutoy242 commented 2 weeks ago
roidrole commented 2 weeks ago

Gendustry Item and Fluid gauges looks out of style. Same for slots of mod Mechanics - Crafting Ways.

Have these been added by the mods themselves or did you use a tweaker mod to create the JEI tabs?

Krutoy242 commented 2 weeks ago

Have these been added by the mods themselves

No, this JEI tabs linked on screenshot is Gendustry native ones. I didnt create them.

roidrole commented 2 weeks ago

All these, except for Schematica, should be fixed in 1.9.0

There should only still be, in terms of incompat form this thread :

Mods which, I believe, hardcoded their GUIs (or, at least, which I can't find a texture for)

Krutoy242 commented 1 week ago

So, since @friendlyhj suggested to use ResourceModLoader, I can add it into E2EE if needed. Please instruct me if this necessary to load your dark mode scripts 😅

roidrole commented 1 week ago

I’m currently trying to make mixins work. For right now, I haven’t been able to, but I made some progress. As such, there’s no benefit to using ResourceModLoader. I’ll update you if/when this changes

Krutoy242 commented 1 week ago

For me, java launch argument -Dmixin.debug.export=true was a big helper.

Krutoy242 commented 4 days ago