rojer / a-s-minus

Awesome Screenshot Minus
102 stars 24 forks source link

Local save button doesn't do anything #13

Open doherty opened 8 years ago

doherty commented 8 years ago

Like it says on the tin: I click the save button, and no save dialog box shows up, and no image is saved anywhere (that I can find, at least). :disappointed:

giorgiobeggiora commented 8 years ago

i have this problem too (it's in the official plugin too). I solved right clicking on image and choosing save image as

bengadbois commented 8 years ago

Same issue, and I use the same solution

giorgiobeggiora commented 8 years ago

probably the problem occours when Flash player is disabled or not installed. If you have Flash player installed but enabled by request, you can right click the button and activate the plugin.

jkayani commented 8 years ago

Hey:

I've looked into this issue, and @giorgiobeggiora is right - it uses Flash to save the image to your computer. With the advent of the HTML5 Download API, which is supported on Chrome, I've removed the dependency on Flash; thus, the feature works as it should, with or without Flash. I'll be issuing a pull request with this fix soon.

rojer commented 8 years ago

thanks Josh! yeah, i made a mental note of the download api, but as per usual - no time. PR will be much appreciated.

KwikOne commented 8 years ago

I found a very simple work-around for this issue. Just click to save on Google drive, then click back - the save button works then

ZeevoX commented 7 years ago

Fixed in commit da8d2481a1c1833f32b836e2f7df8e2210376b77