search

rojer / a-s-minus

Awesome Screenshot Minus
102 stars 24 forks source link

Update desktop capture #19

Closed tayler closed 8 years ago

tayler commented 8 years ago

This may fix issue #6. The plugin uses MediaStream.stop() to stop capturing the desktop. That method is deprecated as of Chrome 45. The update uses the suggested method to end desktop capture.

I tried capture desktop on the latest version of a-s-minus. It didn't fail. It was failing on a fork that I am using though. I can't explain why that is so, but this update fixed it.

rojer commented 8 years ago

i partially fixed this yesterday by 948b36daa4cf07dcd3f4a1d72ddf2a9ca59ffa6f github master branch was behind my local copy, pushed now. release and beta branches have this commit and, unless i screwed something up, 4.0.0.8 should have this already.

however, as your commit shows, i missed the "dismissed notification without capturing" branch in the code, so part of it is useful. please resolve conflict and i'll merge.

thanks!