search

rojer / a-s-minus

Awesome Screenshot Minus
102 stars 24 forks source link

Gdrive folder select #4

Closed jkayani closed 8 years ago

jkayani commented 8 years ago

Hey:

I'm totally new to Chrome Extension Dev, but love using Awesome Screenshot. Noticed I couldn't choose which folder I wanted to save to, so I added the functionality myself. Attached is a screenshot of the UI with my feature. I used jQuery to configure the AJAX request out of simplicity; feel free to provide suggestions for me to clean it up so it can eventually be merged into the main project.

screenshot

rojer commented 8 years ago

thanks! will take a closer look later, but i actually have a branch myself where i started this, but i ran into an issue with folder selector - this one: https://groups.google.com/forum/#!topic/google-picker-api/bZLYFca15Mk

i'll look in more detail later and comment

jkayani commented 8 years ago

Ah OK - I didn't even know about the Picker API! I basically just built this commit from the code already in the extension, using the files.list Drive API to search for untrashed folders (I didn't even know how OAuth worked!). I'm sure the Picker API would be better in terms of UI; my solution is a bit clunky in that regard.

rojer commented 8 years ago

well, the problem with picker api is that it doesn't work - or didn't back when i checked. having something that works is more important than having something that nice in this case :) i'll take a closer look at your PR a bit later - extremely busy with work at the moment.