search

rojer / a-s-minus

Awesome Screenshot Minus
102 stars 24 forks source link

Gdrive folder select #5

Closed jkayani closed 8 years ago

jkayani commented 8 years ago

Re-opening the pull request I had earlier. I modified the UI code to be more user-friendly, though it's still slightly flawed. I like this approach much better than what I had before; it imitates the Google Drive Picker more closely.

rojer commented 8 years ago

sorry for the delay in review, finally got to it and i like what i see. pretty neat way of dealing with hierarchical folders, good job!

this is pretty much ok to merge, other than formatting: can you please make the new code match existing style? namely, tabs -> spaces, tab stop = 2 instead of 8.

rojer commented 8 years ago

oh, and please remove "folder select" from the html page, it's pretty obvious what the dropdown is.

jkayani commented 8 years ago

I committed the changes you prescribed above. Glad I could contribute to the extension (it's my first pull request and project I've ever used Github with). Thanks a lot!

rojer commented 8 years ago

ok Josh, this looks good, i'm merging it. a few more style nits, but i'll fix them up myself.

thanks again for your work! this will go out with the next beta (once i finish some refactoring i've been doing around full page captures).