rojer / a-s-minus

Awesome Screenshot Minus
102 stars 24 forks source link

Shortcut bug #9

Closed odie2 closed 8 years ago

odie2 commented 8 years ago

Hi,

I just tried to write big "ś" (Ctrl+Alt+S) and I was surprised twice by taking screenshot of full page (in this case exactly 26732px height ^^).

I unchecked that shortcut on begin with extension and everything seems right on toolbar and on options page. Edit, wait. It's taking full screen when it's shortcut for selected area. So this is even more strange ._.

Is this may be because Opera (installed extension with Download Chrome Extension) Developer v32.0 Windows? Or it's global bug?

image

image

Greetings

odie2 commented 8 years ago

Hey, any progress? Today tried wrote big "ś" again from 9 days.

rojer commented 8 years ago

sorry, absolutely no time to check this out, especially if it's in opera... all i can say is that i cannot reproduce it in chrome - ctrl-alt-s doesn't trigger anything for me. maybe it has something to do with diacritics, which i don't use... can you try it in chrome?

odie2 commented 8 years ago

Ay, sorry I wrote wrong.

It's Shift + AltGr + S

However in Chrome 43.0.2357.81 the same.

My system locale is default Polish (Programmers). However checked with English and the same.

rojer commented 8 years ago

ha-ha, polish S strikes again :) you know, i even read the article before abot this exact problem - https://medium.com/medium-eng/the-curious-case-of-disappearing-polish-s-fa398313d4df

i blame the original extension authors :) ok, i'll fix it, this should be easy.

odie2 commented 8 years ago

Thanks, will check it and let know.

Interesting article, I am in half of reading ;)

rojer commented 8 years ago

pushed to beta. i'll let it soak there for a day or two since it also picked up gdrive folder select featur, then push to stable.

odie2 commented 8 years ago

Works nice. Thanks again ^^ ŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚŚ