rojo-rbx / rbx-dom

Roblox DOM and (de)serialization implementation in Rust
MIT License
113 stars 46 forks source link

Dont expose `MaterialColorsError` and `UniqueIdError` #355

Closed Dekkonot closed 1 year ago

Dekkonot commented 1 year ago

At the moment, the error types for UniqueId and MaterialColors are exposed. This means that every change to their structure is breaking, including adding variants.

We should use the Error type defined by rbx_types instead. This PR changes it to do that. Additionally, it cleans up an implementation in rbx_xml that relied upon this type being exposed but that's not user facing so it is not noted in the changelog.