rojo-rbx / rbx-dom

Roblox DOM and (de)serialization implementation in Rust
MIT License
113 stars 46 forks source link

Fix saying CFrame components are XVector, YVector, and ZVector #365

Closed kennethloeffler closed 1 year ago

kennethloeffler commented 1 year ago

It turns out that the Roblox documentation was totally wrong and I was misled into writing that CFrame stores the XVector, YVector, and ZVector (these properties are NOT the rows of the matrix - Roblox docs have recently been updated to reflect this). This PR simply writes the components of the rotation matrix in row-major order in our docs for binary CFrame.