Delete generate_reflection

rojo-rbx / rbx-dom

Roblox DOM and (de)serialization implementation in Rust

MIT License

105 stars 42 forks source link

Delete generate_reflection #398

Closed kennethloeffler closed 4 months ago

kennethloeffler commented 4 months ago

generate_reflection was superseded by rbx_reflector in #249. rbx_reflector still has a few issues here and there, but we're now using it entirely in favor of generate_reflection. generate_reflection has not received any updates since, may not work properly anymore, increases compilation times to no purpose, and its presence could confuse new contributors, so it should be removed.

Dekkonot commented 4 months ago

I am potentially worried about the builds failing. Do they fail on master right now or is that a consequence of this deletion?

I am confused either way, but knowing if it's this changes' fault feels important.

kennethloeffler commented 4 months ago

I'm investigating currently. I can't determine why CI is failing. I haven't gotten it to happen locally yet, and I've ensured on the same version of Rust as CI (1.76.0) - but I'll keep you updated!

kennethloeffler commented 4 months ago

I re-ran the build job on master and it fails in the same way: https://github.com/rojo-rbx/rbx-dom/actions/runs/7977827973/job/22222750855. So it's not related to this PR, at least.

Dekkonot commented 4 months ago

All righty then. I suppose we can merge this, then. We should prioritize fixing the CI though.