search

rojo-rbx / rbx-dom

Roblox DOM and (de)serialization implementation in Rust
MIT License
105 stars 42 forks source link

Fix tests by borrowing attributes value in roundtrip test #399

Closed kennethloeffler closed 4 months ago

kennethloeffler commented 4 months ago

After doing tests with a totally clean build (running cargo clean on the workspace, deleting Cargo.lock, then running cargo test --all-features on the workspace), I was able to trace the CI failure we noticed in #398 to an unintentionally breaking change that was shipped as part of a minor version bump to an external library: https://github.com/mitsuhiko/insta/pull/385. It looks like previous versions of the _assert_serialized_snapshot macro borrowed the value, while the new one takes ownership. It is probably better for us to explicitly borrow the value here, but I'll still let them know that this change was breaking

kennethloeffler commented 4 months ago

Closing this because it will Soon be fixed upstream at insta