rojo-rbx / rbxlx-to-rojo

Tool to one time convert Roblox places to Rojo projects
Mozilla Public License 2.0
175 stars 35 forks source link

Decoding place file no longer works after latest Roblox update #44

Open lextoumbourou opened 3 years ago

lextoumbourou commented 3 years ago

After latest Roblox update, Studio version: 0.473.0.420291 rbxlx-to-rojo no longer works and returns this error:

An error occurred while using rbxlx-to-rojo.
While attempting to decode the place file, at line 65, column 3: Unknown property type 'OptionalCoordinateFrame' rbx_xml didn't know what to do

Looks like Roblox may have added an additional property that the decoder doesn't like.

lextoumbourou commented 3 years ago

A temporary work around for anyone that comes across this is to remove the OptionalCoordinateFrame lines from the rbxlx file as follows:

grep -vwE "OptionalCoordinateFrame" PlaceFile.rbxlx > PlaceFileNew.rbxlx
Kampfkarren commented 3 years ago

This is a new data type that rbx-dom doesn't support yet. Can you file a feature request over there to support this?

lextoumbourou commented 3 years ago

Looks like someone already has: https://github.com/rojo-rbx/rbx-dom/issues/167

Thanks for your help!

Kampfkarren commented 3 years ago

In the future, I want to work with @LPGhatguy on being able to ignore unknown types like this, otherwise it creates a problem where we need to release a new version every time something we don't even use gets released.

Kampfkarren commented 3 years ago

Can you tell me if this version works?

https://github.com/rojo-rbx/rbxlx-to-rojo/suites/2471064074/artifacts/53133886

lextoumbourou commented 3 years ago

I'm on Mac, but the mac version from that build seems to work. Thanks for getting on it so fast!

RemielDev commented 3 years ago

Looks like someone already has: rojo-rbx/rbx-dom#167

Thanks for your help!

Where can I place the temporary fix code?

Firere commented 2 years ago

Should this issue be closed? I'm having the same problem a year later and I don't know if I should open up another issue

Kampfkarren commented 2 years ago

Probably just need to update the rbx-dom crates, it's easy enough to where I should be able to do it