search

rojo-rbx / remodel

Scriptable Roblox multitool: Manipulate instances, model files, places, and assets on Roblox.com
MIT License
169 stars 38 forks source link

Update reqwest to a ClientBuilder, and extend the timeout to 3 minutes #63

Closed unix-system closed 3 years ago

unix-system commented 3 years ago

Problem When uploading or downloading big assets, remodel defaults to the reqwest library default timeout, which is only 30 seconds (according to reqwest/src/blocking/client.rs#L349)

Solution Increase the timeout to three minutes. This is an arbitrary number but it seems sensible.

unix-system commented 3 years ago

I've read that build fail - it doesn't give any helpful information except that there is a file diff. I managed to upload my test file successfully; it took nearly 3 minutes but it worked regardless. Would it be a good idea to just remove timeout altogether?

unix-system commented 3 years ago
LPGhatguy commented 3 years ago

We talked about this on Discord a bit. Let me know when you've filed the DevForum post about this issue. It shouldn't take anywhere near 3 minutes to upload a place that's only 60 MB!