search

rojo-rbx / rojo

Rojo enables Roblox developers to use professional-grade software engineering tools
https://rojo.space
Mozilla Public License 2.0
908 stars 172 forks source link

Lint plugin src #846

Closed boatbomber closed 5 months ago

boatbomber commented 5 months ago

This has been on my pet peeves list for a while.

Enforces selene via CI. This PR comes with a whole bunch of tiny fixes for things that make my editor yell at me whenever I work on Rojo.

Also, after fixing lints on createSignal I noticed that it's totally unused. It's 4 years old with the last commit being "for future work" which evidently never came. So, I removed it.

Dekkonot commented 5 months ago

Next step: static types, right? :P

boatbomber commented 5 months ago

We'll drag Rojo into the modern era kicking and screaming if we have to