Build tree ancestry correctly

rojo-rbx / rojo

Rojo enables Roblox developers to use professional-grade software engineering tools

https://rojo.space

Mozilla Public License 2.0

908 stars 172 forks source link

Build tree ancestry correctly #882

Closed boatbomber closed 4 months ago

boatbomber commented 4 months ago

I really screwed this one up. Don't know how I managed that.

Tree was being built out of order, but only for some change types. This meant that some changes built a good tree, some built an upside down one. I suppose that's how it slipped past us.

Dekkonot commented 4 months ago

Can you provide an example of a tree that built upside down so that we can verify it's been fixed?

boatbomber commented 4 months ago

Project Structure:

From master: Note how ReplicatedStorage > Common > Apple is upside down

From fix/patch-tree-build-ancestry: