rojo-rbx / rojo

Rojo enables Roblox developers to use professional-grade software engineering tools
https://rojo.space
Mozilla Public License 2.0
906 stars 170 forks source link

Trim plugin version string #890

Closed EgoMoose closed 3 months ago

EgoMoose commented 3 months ago

Duplicate of https://github.com/rojo-rbx/rojo/pull/889, but based on master as per request.

This PR is a very small change that fixes the string pattern that reads the rojo version from Version.txt. Currently this reads an extra new-line character which makes reading the version text in the plugin difficult.

It seems the rust side of things already trims the string when comparing, but the lua side does not.

Current: pO6gtOXAZq

Fix: RobloxStudioBeta_GHmiJKAoa3

Apologies if I skipped over some process of submitting a bug and / or am basing on the wrong branch etc.