Closed kennethloeffler closed 5 months ago
Does using GitHub's CLI for creating a release substantially increase the complexity? Glancing at the docs makes me think no, and it's probably worth using it over an action even if it adds a small delay.
Otherwise, I like the changes and thank you for taking care of this. Touching workflows is always work I want to do but never get around to.
This PR performs a number of relatively straightforward maintenance tasks and improvements for the "Release" workflow:
Upgrades to actions/checkout@v4 and switches to dtolnay/rust-toolchain instead in favor of actions-rs/toolchain
Reasoning is the same as #900
Switches to softprops/create-gh-release
actions/create-release is unmaintained and has been archived for more than three years.
I considered using the GitHub CLI's (which is preinstalled on GitHub-hosted runners)
gh release create
to do this so we wouldn't have to pull in another third-party action, but it requires a checkout first - but doing this only adds a few more seconds before the release is created comapred to create-gh-release, so it may be acceptable?Switches to using preinstalled GitHub CLI to upload release archives
There's absolutely no point in using a third party action for this, so we won't!
Simplifies the and consolidates the way we generate names for release archives
Here's an example of the results of this workflow on my fork: https://github.com/kennethloeffler/rojo/actions/runs/8642870695 https://github.com/kennethloeffler/rojo/releases/tag/v7.4.0-releasevvv-workflow-tewstingsbvv