rojo-rbx / rojo

Rojo enables Roblox developers to use professional-grade software engineering tools

https://rojo.space

Mozilla Public License 2.0

906 stars 170 forks source link

Use msgpack for API #908

Open nezuo opened 2 months ago

nezuo commented 2 months ago

Fixes #363. Fixes #881.

Remaining Tasks

[ ] Test more extensively.
[x] Use msgpack for write api request.
[x] Handle NaN inside of patch compute.

nezuo commented 2 months ago

patch_compute.rs will treat NaN properties as always changed. This means that you will see nan property changes in the rojo plugin UI (when nothing actually changed).

I'm not sure what's the best way to go about fixing this. Ideally we also account for it types that have multiple numbers like CFrame or NumberSequence.

nezuo commented 1 month ago

I just pushed a commit to account for NaN values. It's a lot of complexity just to handle NaN (and hopefully we don't forget to update it with any new variants because Variant is non_exhaustive). I'm not really sold on the approach, but I'd like to hear anyone's thoughts on it.

nezuo commented 1 month ago

I'm now using the variant_eq function from your fork. I did change the the Attributes comparison to simplify it if you want to check that out.

nezuo commented 1 month ago

That's my bad, I thought I removed it.