search

rojo-rbx / rojo

Rojo enables Roblox developers to use professional-grade software engineering tools
https://rojo.space
Mozilla Public License 2.0
906 stars 170 forks source link

Use history recording and don't do anything permanent #915

Closed boatbomber closed 1 month ago

boatbomber commented 1 month ago

Adopts the latest ChangeHistoryService APIs. Our Undo/Redo notification warnings (to prevent accidentally undoing a Rojo patch) still work fine with this new API.

Avoids the permanent Destroy action, uses Remove instead. This closes #914.

boatbomber commented 1 month ago

not much we can do about it, but I'm still unhappy

Sums up a lot of Rojo work, doesn't it 😭

kennethloeffler commented 1 month ago

Does the problem in the linked issue only occur for changed class names? We destroy instances for normal removals, too

boatbomber commented 1 month ago

Good catch, Ken. Updated all uses of Destroy to be Parent = nil, and updated all the relevant tests to pin this behavior.