rojo-rbx / rojo

Rojo enables Roblox developers to use professional-grade software engineering tools
https://rojo.space
Mozilla Public License 2.0
912 stars 171 forks source link

Add a `$paths` field for folders #936

Open Nolan-O opened 2 weeks ago

Nolan-O commented 2 weeks ago

Not sure if this is an acceptable feature but I wanted to see if it was possible 🙂

Allows a roblox folder's contents to be the sum of multiple flesystem folders' contents. Enhances the ability for rojo to change a project's form based on project files. E.G. multi-place games, libraries with tiered features for releases, a tests.project.json file

This feature may conflict with syncback since it introduces an ambiguity where new contents of a roblox folder should be stored. If possible, I think it would be acceptable to use the first path in the list of paths as a "dominant" one, treating it like the base folder on the filesystem.

Notes:

Dekkonot commented 1 week ago

Howdy! I'm going to wait to give this a review until syncback is merged since rather selfishly I don't want to handle the merge conflicts on a PR that's already massive. I will get back to you though, promise.

Nolan-O commented 1 week ago

Agreed tbh, makes sense for the large structural change to go first. This PR should have to work with syncback rather than the other way around.