rojo-rbx / rojo

Rojo enables Roblox developers to use professional-grade software engineering tools
https://rojo.space
Mozilla Public License 2.0
939 stars 176 forks source link

Support ARM64 for Windows and Linux #967

Open howmanysmall opened 3 weeks ago

howmanysmall commented 3 weeks ago

Bought a new WinArm laptop, and was wondering if it would be possible to add building arm64 (Windows and Linux, if possible) to the workflow to support it. I can emulate it, but I am already emulating Roblox Studio so I'd really like to keep that to a minimum. Shouldn't be too hard either since it's just an action.

Dekkonot commented 3 weeks ago

Please do not instruct people to download random files.

howmanysmall commented 3 weeks ago

I don't see where I did?

Dekkonot commented 3 weeks ago

Sorry, that wasn't aimed at you! I had to mark two comments as abusive because they both contained links to zip files and sketchy instructions.

howmanysmall commented 3 weeks ago

ah that was a bit of a jumpscare

Dekkonot commented 2 weeks ago

Upon looking into this, I'm not sure how much we can support this. Windows on ARM is listed as a tier 2 host for Rust, which means that sometimes things just won't work. Given that we also can't run CI for these platforms, I'm skeptical of attaching it to every release.

Additionally, some of our dependencies have custom build scripts. I don't know how they will play with aarch64. You may need to build this yourself and report back because I don't possess a native aarch64 device, let alone an aarch64 windows one.

howmanysmall commented 2 weeks ago

If you ned a test machine, I'm glad to help. I'd rather just have it for ubuntu if that's possible

Dekkonot commented 2 weeks ago

I asked GitHub and they attempted to upsell me their Large runners. I'm guessing that they do not have plans for ARM64 support for normal runners any time soon.

If you can confirm that it passes tests, we can for sure start making releases of aarch64-linux. I have full confidence it'll build, I'm mostly just worried about the system specific problems like the file watcher.

howmanysmall commented 2 weeks ago

image image image

Builds and passes tests on my machine.

Dekkonot commented 2 weeks ago

I'll make sure that we get it added to our release workflow then!

No promises on a timeline as RDC is just around the corner though.

howmanysmall commented 2 weeks ago

Take your time, I can just build it when you update for now.