search

rojo-rbx / rokit

Next-generation toolchain manager for Roblox projects
MIT License
72 stars 13 forks source link

Fix accepting different token types #60

Closed Midnightific closed 3 months ago

Midnightific commented 3 months ago

Fixes accepting different token types

If no one’s got objections I’ve started writing up a draft of a GitHub action for rokit so I’d love to be the one to publish it if that’s okay.

Removing regex was @Dekkonot's suggestion so if you can somehow add him as a coauthor that'd be great!

Midnightific commented 3 months ago

Sorry just realised I left the test in there, if someone could remove that then that’d be great 😅(as I’ve gotten off for the night)

Paracosm-Daemon commented 3 months ago

Glad to see this. I switched to Rokit recently for a few things I'm working on, and the token auth issue completely severed my ability to publish packages via GitHub Actions.

If no one’s got objections I’ve started writing up a draft of a GitHub action for rokit so I’d love to be the one to publish it if that’s okay.

Sidenote- this was already made, but it's currently nonfunctional due to the aforementioned issue.

Midnightific commented 3 months ago

Yeah I didn't know that until yesterday but as long as someone's done it then that's fantastic! 😄