search

rojo-rbx / vscode-rojo

Visual Studio Code plugin for Rojo
https://marketplace.visualstudio.com/items?itemName=evaera.vscode-rojo
Mozilla Public License 2.0
36 stars 23 forks source link

Implement support for macOS #2

Closed anton-matosov closed 5 years ago

anton-matosov commented 5 years ago

Install Rojo in macOS using cargo

Update libs to latest versions to fix ts build errors and security audit warnings

evaera commented 5 years ago

This looks really great! Thanks for working on this. Especially thankful because I retired my Macbook a while ago, so I wouldn't have had any way to test that it was working correctly (I assume you did test it on macOS :P )

anton-matosov commented 5 years ago

You are welcome! Yes, I have tested it extensively on Mac. However I didn't run regression test on Windows yet because I have retired my Windows machine )) and need more time recovering it and setting up everything there. It will be great if you can help re-testing the Windows part

evaera commented 5 years ago

Yeah, no worries, will test on Windows.

evaera commented 5 years ago

Tested on Windows and still seems to work great. thanks

evaera commented 5 years ago

Hey @anton-matosov, this is live now. Please let me know if anything is wrong with the live version after our changes (it seems to be working fine for me on Windows 😄)

anton-matosov commented 5 years ago

Installed from vscode marketplace, all looks good!