search

rojo-rbx / vscode-rojo

Visual Studio Code plugin for Rojo
https://marketplace.visualstudio.com/items?itemName=evaera.vscode-rojo
Mozilla Public License 2.0
36 stars 23 forks source link

Fixed bug that wouldn't shut down Rojo instances after a quit. #28

Closed joeldesante closed 4 years ago

joeldesante commented 4 years ago

First off, I'd just like to note that this is my first time submitting to an open source project. So if I am doing this wrong please tell me.

I am submitting this pull request because I was experiencing an issue on my Mac system where Rojo instances would never shut down until I manually killed them using the following commands:

lsof -li :34872
kill -9 PID

I believe I may have fixed this issue by adding what appears to be the Rojo stop function in the deactivation method.

Please let me know what you think.

ryanlego commented 4 years ago

Thanks, I've sent it to the maintainer.