search

rojopolis / spellcheck-github-actions

Spell check action
MIT License
132 stars 38 forks source link

Silent mode #19

Closed edumco closed 3 years ago

edumco commented 4 years ago

Would be nice to have a silent mode so it doesn't break CI for some files or branches

We could have an breaking action for PR and a silent for the branches

What do you think about it?

jonasbn commented 4 years ago

@edumco sounds like a good idea. Hacktoberfest is coming up, perhaps we good look into it there

jonasbn commented 3 years ago

Hi @edumco

I have been thinking about this and got to a point where I got stuck on your silent mode request.

  1. First I was thinking, you just wanted it to run, but not log anything, which is doable.
  2. Then I learned the other day that you can target your workflows to specific branches See GitHub Actions documentation

Which brings me to your original request. So what do you mean when you say silent mode ?

The first part could be addressed as a feature implementation.

The second part should be doable using workflow configuration, which then just require some more documentation on how to enable this or perhaps a combination of an implementation and workflow management.

Looking forward to hearing from you.

edumco commented 3 years ago

@jonasbn Im sorry i loose track on my github account (2020 was hard)

I realized that what I was suggesting fits on the second category: Make documentation more clear about where it should break the pipeline

edumco commented 3 years ago

I'm closing this issue cause now I believe the documentation already covers it