rojopolis / spellcheck-github-actions

Spell check action
MIT License
132 stars 38 forks source link

Build Docker image #43

Closed edumco closed 3 years ago

edumco commented 3 years ago

This adds another parallel job to github actions to build the docker image

In the future is possible to use this docker image to publish to a container registry or simply to test if it works correctly

jonasbn commented 3 years ago

Hi @edumco

This looks promising and the idea of doing CI of the Docker build process sounds very interesting. As I understand the image is discarded post build - for now?

edumco commented 3 years ago

@jonasbn Yes, for now it wont publish. I'm taking baby steps

jonasbn commented 3 years ago

Hi @edumco

This is a paving the way I want to go BUT the reason I am reluctant is the publishing part.

This most likely require some sort of authentication/authorization, possibly based on a GITHUB_TOKEN. Since this it not my repository, the is not an available option as such.

Any ideas or suggestions are most welcome.

edumco commented 3 years ago

Hi @jonasbn. I agree with you. But this pull request only validates the docker building process.

The Docker release must be done in a future pull request.

In a first moment I though just to make possible download the image as an build artifact to run tests in the pipeline and in a second moment make the tested images available as public image with the latest tag on github

jonasbn commented 3 years ago

HI @edumco

Then lets start here