search

rojopolis / spellcheck-github-actions

Spell check action
MIT License
138 stars 38 forks source link

Push image to Docker Hub or GitHub Packages #9

Closed tomlankhorst closed 4 years ago

tomlankhorst commented 4 years ago

The image is built on every run. The process could be sped up significantly by pushing the Dockerfile to Docker Hub (for automatic building) or GitHub packages and then use it from there.

Do you consider this an option?

jonasbn commented 4 years ago

It is quite slow

jonasbn commented 4 years ago

Hi @tomlankhorst

I have just release 0.4.0 to GitHub Marketplace. Next up is addressing this particular issue.

edumco commented 4 years ago

It is quite slow

The image itself could be improved for performance, build time and download time by:

jonasbn commented 4 years ago

Hi @tomlankhorst and @edumco

I have pushed a "jonasbn/github-action-spellcheck:0.5.0" to DockerHub.

Would any of you be interested in reviewing it, the code is available in PR: #12

I have labelled the Docker image 0.5.0 since I expect it to be a part of the 0.5.0 release of the action, it is however also available as: "jonasbn/github-action-spellcheck:latest".

If do not hear anything I expect to release 0.5.0 to the Marketplace within a few days.

jonasbn commented 4 years ago

@edumco please see my comment in PR #12 on Alpine. I am not giving up on slimming down the image even further, but I am not so familiar with Alpine, so it will take some time to get into possibly addressing the issues observed with the XML and XSLT dependencies, which demonstrate issues when building on Alpine.

edumco commented 4 years ago

@edumco please see my comment in PR #12 on Alpine. I am not giving up on slimming down the image even further, but I am not so familiar with Alpine, so it will take some time to get into possibly addressing the issues observed with the XML and XSLT dependencies, which demonstrate issues when building on Alpine.

The suggestions I made dont need to happen all together. Alpine is a little tricky. In some cases makes the dockerfile more complex. I will look the PR :dancers: