search

roke-to / roketo-contract

The Unlicense
4 stars 1 forks source link

Streaming: inactive streams must not contain stopped streams #3

Closed Kouprin closed 2 years ago

Kouprin commented 2 years ago

https://github.com/roke-to/roketo-contract/blob/master/streaming/src/stream.rs#L184

When finished stream is paused, it got stopped automatically. However in this case it should be removed from inactive_streams. The check is_terminated similar to https://github.com/roke-to/roketo-contract/blob/master/streaming/src/stream.rs#L231 expected to be used here.

+needs a test to check stream status consistency

Kouprin commented 2 years ago

Users also need to be fixed.

Kouprin commented 2 years ago

@MikhailRubinchik confirmed there are no broken users at the contract, closing the issue