rokka-io / imagine-vips

libvips adapter for php imagine
https://rokka.io
Other
41 stars 8 forks source link

Update text functions #38

Closed devzzm closed 1 year ago

devzzm commented 1 year ago

This will make this library handle text like the other Imagine adapters. I left the "with height" function alone so if someone expects the prior behavior, they can call that directly. However, swapping between adapters will present similar results now. I could not get the library to render animated gif so I did not make the text method work with that (and overall, Imagine can't handle animated png or webp either).

chregu commented 1 year ago

Thanks a lot. Looks good to me. Will write a proper Changelog, that this is a BC break, with an easy fallback.

Linting currently fails -> https://github.com/rokka-io/imagine-vips/actions/runs/3535074601/jobs/5939076599 Can you fix that? composer lint:fix should be enough.

chregu commented 1 year ago

I'll do it for you after the merge