search

rokubun / android_rinex

This repository contains a python script that converts logs from Google's GNSS measurement tools to RINEX
BSD 2-Clause "Simplified" License
83 stars 33 forks source link

Bug fixes and enhancements in processing #5

Closed dmiralles2009 closed 5 years ago

dmiralles2009 commented 5 years ago

Greetings, I found this repo quite useful and spend the last couple of weeks working in some bug fixes and improvements to the code. Thanks for initiating this project, the Python front end, and processing is well designed. Current changes include:

  1. Fix GLO and BDS pseudorange computation based on received time.
  2. Add some required RINEX V3.03 header fields
  3. Add processing modes for the file generation as "sync" or "trck", which performs different levels of state check before measurement generation.
  4. Filter out incorrect measurements before generating RINEX v3.03 file
  5. Adjust measurement observation codes given the signal type for GAL E1B, GAL E1C, and BDS B1I.

Hope you find this useful. Happy to continue collaboration if you find it fit.

Best, Damian

oostern commented 5 years ago

In get_glo_freq_chn_list you don't catch the ValueError potentially thrown by get_satname

I'd submit a pull request myself, but I'm on mobile and wouldn't be able to actually test it

Cheers, colton

rokubun commented 5 years ago

Thanks Damian for your contributions! I've rebased them into master

Best

Miquel

dmiralles2009 commented 5 years ago

You are welcome. I did not have the chance to mix some of the comments on my own but they made a lot of sense. Thanks again