rokucommunity / brighterscript

A superset of Roku's BrightScript language
MIT License
162 stars 46 forks source link

More validation performance #1110

Closed markwpearce closed 7 months ago

markwpearce commented 7 months ago

Refactors local variable checking to only check un-changed AstSegments for function shadowing if those segments make an assignment to a symbol that changed.

Before:

validate@local   ---------- 51.368 ops/sec
validate@0.65.26 --------- 101.435 ops/sec

After:

validate@local   --------- 286.331 ops/sec
validate@0.65.26 --------- 102.877 ops/sec
TwitchBronBron commented 7 months ago

Woah! That's some serious performance improvements!!! I'll test this out in our huge project to make sure it didn't break anything, but I'm super excited about this