search

rokucommunity / brighterscript

A superset of Roku's BrightScript language
MIT License
153 stars 47 forks source link

fix: resolve the stagingDir option relative to the bsconfig.json file #1148

Closed bartvandenende-wm closed 2 months ago

bartvandenende-wm commented 3 months ago

Summary

fix: resolve the stagingDir option relative to the bsconfig.json file

Details

Resolve stagingDir relative to the bsconfig.json file similar to the other paths.

⚠️ This is a breaking change in behaviour of the bsconfig.json.

solves https://github.com/rokucommunity/brighterscript/issues/1141

Repro steps

given the below two config files

  1. ./node_modules/shared-config/bsconfig.json

    "rootDir": "../../src",
"stagingDir": "../../build"

  2. ./bsconfig.json

    {
"extends": "./node_modules/shared-config/bsconfig.json",
}

    Expected result:

$ rootDir: {cwd-dir}/src
$ stagingDir: {cwd-dir}/build

How it was tested

unit test