rokucommunity / brighterscript

A superset of Roku's BrightScript language
MIT License
152 stars 47 forks source link

Elevate `thenby` to a prod dependency #1217

Closed TwitchBronBron closed 1 month ago

TwitchBronBron commented 1 month ago

We started using thenby as a prod dependency, but it was marked as a devDependency which causes crashes at runtime.

Error: Cannot find module 'thenby'
Require stack:
- /<redacted>/node_modules/brighterscript/dist/Program.js
- /<redacted>/node_modules/brighterscript/dist/ProgramBuilder.js
- /<redacted>/node_modules/brighterscript/dist/index.js
- /<redacted>/.vscode/extensions/rokucommunity.brightscript-2.48.5/dist/LanguageServerRunner.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1084:15)
    at Module._load (node:internal/modules/cjs/loader:929:27)
    at c._load (node:electron/js2c/node_init:2:13672)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/<redacted>/node_modules/brighterscript/dist/Program.js:43:18)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1326:10)
    at Module.load (node:internal/modules/cjs/loader:1126:32)
    at Module._load (node:internal/modules/cjs/loader:967:12)
    at c._load (node:electron/js2c/node_init:2:13672)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/<redacted>/node_modules/brighterscript/dist/ProgramBuilder.js:7:19)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1326:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/<redacted>/node_modules/brighterscript/dist/Program.js',
    '/<redacted>/node_modules/brighterscript/dist/ProgramBuilder.js',
    '/<redacted>/node_modules/brighterscript/dist/index.js',
    '/<redacted>/.vscode/extensions/rokucommunity.brightscript-2.48.5/dist/LanguageServerRunner.js'
  ]
}

Node.js v18.18.2
[Error - 10:27:43] Connection to server got closed. Server will not be restarted.