search

rokucommunity / brighterscript

A superset of Roku's BrightScript language
MIT License
152 stars 47 forks source link

Multi-dimensional array syntax not supported #293

Open luis-soares-sky opened 3 years ago

luis-soares-sky commented 3 years ago

While testing converting our project to BrightScript, we noticed the Language Server didn't like the multi-dimensional array access syntax array[x, y, ...], even though it's supported in the base language.

image

Reference: https://developer.roku.com/en-gb/docs/references/brightscript/language/expressions-variables-types.md#array-operator

elsassph commented 3 years ago

Something to add to the branch adding support for Dim...

TwitchBronBron commented 3 years ago

@chrisdp is this something you have already addressed in your PR?

chrisdp commented 3 years ago

@TwitchBronBron I did not but I can. I actually mentioned this when looking at dim because we didn't know this was valid till that point. Just let me know if you want me to or if you want it as it's own.

TwitchBronBron commented 3 years ago

I think I'd like them separate, just so we can add dim support sooner.

chrisdp commented 3 years ago

@TwitchBronBron sure. Sounds good. I'll try and finish Dim start of the week and see if I can whip this together quickly as well.

TwitchBronBron commented 3 years ago

@chrisdp now that the initial dim PR is complete, do you still think you can get to fixing this soon-ish?

chrisdp commented 3 years ago

I did not end up having the bandwidth to get to this. If someone else wants to take a stab at it I would say feel free to do so.