rokucommunity / brighterscript

A superset of Roku's BrightScript language
MIT License
160 stars 46 forks source link

Add "Brighterscript" to Github's Linguist #451

Closed markwpearce closed 2 years ago

markwpearce commented 3 years ago

It would be great if Brighterscript was listed as a real language in Github repos!

https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-a-language

elsassph commented 3 years ago

Yeah I've looked into that, but to make a PR to just associate .bs with the BrightScript syntax you need to prove that there are "hundreds" of repositories using it...

- [ ] **I am associating a language with a new file extension.**
  - [ ] The new extension is used in hundreds of repositories on GitHub.com
    - Search results for each extension:
      <!-- Replace FOOBAR with the new extension, and KEYWORDS with keywords unique to the language. Repeat for each extension added. -->
      - https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

Then if you actually search, I could find another languages/tools using .bs:

TBH the real deal is that we should seriously look again at using .brs even for brighterscript code...

TwitchBronBron commented 2 years ago

This was resolved by https://github.com/github/linguist/pull/5643