disable next line doesn't seem to work

[georgejecook]

'bs:disable-next-line
 m.top.sdkTask.exit = true

still results in error

[TwitchBronBron]

@georgejecook is this still an issue?

[markwpearce]

this is still an issue... with VS Code Brightscript language extension 2.1.21 (uses brightscript@0.10.0)

  'bs:disable-next-line
  Dim requestData[requestList.count()]

still results in error (Found unexpected token 'Dim')

[TwitchBronBron]

@markwpearce can you provide any additional steps to reproduce? This works just fine for me.

[TwitchBronBron]

I have refactored the disable comments to support leading whitespace, and also to utilize the tokenizer instead of splitting the source file by newline and manually parsing it. Hopefully one of these two things has resolved your issue. #108

[TwitchBronBron]

@markwpearce any updates on this?

[markwpearce]

Running version 2.4.4, it still shows up as a "problem" with red underline in vs Code.

sub testDimNoDisable()
  dim array[3]
end sub

sub testDimWithDisable()
  'bs:disable-next-line
  dim array[3]
end sub

Both of the "dim" statements above get the red underline, with

{ "resource": "test.brs", "owner": "_generated_diagnostic_collectionname#0", "code": "1081", "severity": 8, "message": "Found unexpected token 'dim'", "source": "brs", "startLineNumber": 2, "startColumn": 3, "endLineNumber": 2, "endColumn": 6 }

[TwitchBronBron]

@markwpearce is this still an issue?

[markwpearce]

Nope! I'll close it