add logic for optional chaining

rokucommunity / brs

An interpreter for the BrightScript language that runs on non-Roku platforms.

MIT License

4 stars 2 forks source link

add logic for optional chaining #21

Closed nadiapadalka closed 10 months ago

nadiapadalka commented 10 months ago

Added logic for optional Chaining

added tests as well
now any warnings do not appear

Addressing #20

TwitchBronBron commented 10 months ago

@nadiapadalka looks like the build is currently failing. Can you fix the issues?

Here are all the commands we run as part of the build. https://github.com/rokucommunity/brs/blob/ab5322aff7c2f4b96f1608f233be05e25bb2b75e/.github/workflows/build.yml#L25-L30

nadiapadalka commented 10 months ago

@TwitchBronBron fixed

nadiapadalka commented 10 months ago

@TwitchBronBron Hi! The question to you: how can we see this change in our testing environment? Should we make the new release with this PR included or what?

TwitchBronBron commented 10 months ago

I actually just cut a new release this morning that includes this change. If you upgrade to @rokucommunity/brs v0.45.2, you should see the change.

I apologize for taking so long to get the release out. We were waiting to get a few additional fixes in, and then I got super busy the past few days.

Thanks again for submitting this fix!

nadiapadalka commented 10 months ago

I actually just cut a new release this morning that includes this change. If you upgrade to @rokucommunity/brs v0.45.2, you should see the change.

I apologize for taking so long to get the release out. We were waiting to get a few additional fixes in, and then I got super busy the past few days.

Thanks again for submitting this fix!

oh, good to hear! thanks!

nadiapadalka commented 10 months ago

Next question - maybe you can give the advice to me how to upgrade the version correctly? I tried different steps, but seems they are not working

TwitchBronBron commented 10 months ago

This is a fork of the original project, so you might need to change a reference or two in your code depending on how you're running it. Are you using brs directly or is it being used from another tool?

You might need to do this:

npm uninstall brs
npm install @rokucommunity/brs

If you're using the brs cli directly, that's probably all you need to do

nadiapadalka commented 10 months ago

Thanks! But any succcess from my side. Maybe you can try from your side to run any test? Because everything I see now is like this

TwitchBronBron commented 10 months ago

Are you using roca for your tests? We don't have any control of that project, and I don't believe there's currently a way to override their embedded version of brs to use Rokucommunity/brs.