search

rokucommunity / bslint

A linter for BrightScript and BrighterScript.
MIT License
28 stars 14 forks source link

updates to bsc 0.45.3 #53

Closed georgejecook closed 2 years ago

georgejecook commented 2 years ago

this resolves down stream chaos, for other plugin vendors, as running bslint presently, uses the wrong method signatures for bsc plugin callbacks.

elsassph commented 2 years ago

Really odd @TwitchBronBron - the brighterscript dependency breaks bslint as apparently the isCalled property was removed. I added that inititially to know whether the variable was used in a function call. It may require some logic change or removing this test and just always saying that the variable doesn't exist.

TwitchBronBron commented 2 years ago

I removed that property because it wasn't being used anywhere in brighterscript. I believe it was left over from when we ported the parser from the brs runtime. I hadn't realized that bslint was using it. Not sure adding it back in is the correct answer, but I can put it back into v0 if you really think it's important. I'll definitely be removing isCalled from v1.

Looks like it was set any time we created a new callExpression, and the callee was a variable expression: https://github.com/rokucommunity/brighterscript/commit/285a182e2468044223539b59e1854b99163dac1a

elsassph commented 2 years ago

@TwitchBronBron it was me who had added this property to help writing bslint :D I'll need to track that differently.

elsassph commented 2 years ago

Fixing that properly in another PR