[WIP] Color format checking for bslint

rokucommunity / bslint

A linter for BrightScript and BrighterScript.

MIT License

28 stars 15 forks source link

[WIP] Color format checking for bslint #94

Closed disc7 closed 1 year ago

disc7 commented 1 year ago

proposed way to check for color formatting in brs and bs files.

0xW1sKy commented 1 year ago

does this also include transparency suffix?

I believe that bs will accept: "FFFFFF", "0xFFFFFF", or "0xFFFFFF00"

I'd recommend it forces the 0x prefix as well as the transparency suffix 00-FF as part of the linting check.

disc7 commented 1 year ago

Not yet. I've got a local branch with alpha values allowed, default alpha allowed, case (upper or lower) and Roku broadcast safe color cert requirement compliance.

Once I know we can determine a range to flag known color styling issues (in brs / bs and xml files - given that there is no color token type in ESlint) will update this to include those.

TwitchBronBron commented 1 year ago

I've just pushed some changes.

I think I handled the template string quasi logic correctly now.
I simplified the tests by keeping the testable code inline right above the expectations.
I moved the color tests into their own describe block.

@elsassph any other concerns?