common:/LibCore/v30/bslCore.brs path improperly modified in component libraries

[triwav]

If you include it like <script type="text/brightscript" uri="common:/LibCore/v30/bslCore.brs"/> in a component library it tries to convert that to something like <script type="text/brightscript" uri="common:/LibCore/v30/bslCore__lib2.brs"/> which then causes the component library to fail to load due that file not existing. Probably the best way to handle is to make sure that the path is pkg:/ before trying to modify the path for it.

[TwitchBronBron]

Here's a unit test that can be placed within ProjectManager.spec.ts somewhere.

describe('postfixFiles', () => {
    it('skips "common:/" paths', async () => {
        let project = new ComponentLibraryProject(params);
        project.fileMappings = [];
        fsExtra.outputFileSync(`${params.stagingFolderPath}/source/main.brs`, '');
        fsExtra.outputFileSync(`${params.stagingFolderPath}/components/Component1.xml`, `
            <component name="CustomComponent" extends="Rectangle">
                <script type="text/brightscript" uri="common:/LibCore/v30/bslCore.brs"/>
                <script type="text/brightscript" uri="CustomComponent.brs"/>
                <script type="text/brightscript" uri="pkg:/source/utils.brs"/>
            </component>
        `);
        await project.postfixFiles();
        expect(
            fsExtra.readFileSync(`${params.stagingFolderPath}/components/Component1.xml`).toString()
        ).to.eql(`
            <component name="CustomComponent" extends="Rectangle">
                <script type="text/brightscript" uri="common:/LibCore/v30/bslCore.brs"/>
                <script type="text/brightscript" uri="CustomComponent__lib0.brs"/>
                <script type="text/brightscript" uri="pkg:/source/utils__lib0.brs"/>
            </component>
        `);
    });
});

[philandersonaccedo]

Picking up this ticket for investigation

[philandersonaccedo]

Notes on 1-1 session

• Issues with XML library import eg Githubissues.
• Githubissues is a development platform for aggregating issues.