A compatibility wrapper around the BrightScript debug protocol https://developer.roku.com/en-ca/docs/developer-program/debugging/socket-based-debugger.md
MIT License
13
stars
9
forks
source link
Fix "continue" repeat bug in protocol adapter #114
Due to a bug in the 11.5 Roku OS firmware, breakpoints created via the ADD_CONDITIONAL_BREAKPOINTS would hit multiple times when pressing "continue". This PR changes the logic to only use ADD_CONDITIONAL_BREAKPOINTS for breakpoints that have conditional expressions. All other breakpoints will be sent using the standard ADD_BREAKPOINTS request instead. This means you only pay the "continue" penalty for conditional breakpoints.
Also fixed an issue with sending breakpoints to the device while running.
Due to a bug in the 11.5 Roku OS firmware, breakpoints created via the
ADD_CONDITIONAL_BREAKPOINTSwould hit multiple times when pressing "continue". This PR changes the logic to only useADD_CONDITIONAL_BREAKPOINTSfor breakpoints that have conditional expressions. All other breakpoints will be sent using the standardADD_BREAKPOINTSrequest instead. This means you only pay the "continue" penalty for conditional breakpoints.Also fixed an issue with sending breakpoints to the device while running.