search

rokucommunity / roku-debug

A compatibility wrapper around the BrightScript debug protocol https://developer.roku.com/en-ca/docs/developer-program/debugging/socket-based-debugger.md
MIT License
13 stars 9 forks source link

Value of stopDebuggerOnAppExit in Launch.json is ignored #159

Closed jimallison53 closed 1 year ago

jimallison53 commented 1 year ago

The plugin ignores the value of "stopDebuggerOnAppExit ". Proper syntax of "stopDebuggerOnAppExit " in Launch.json requires a value, e.g.

"stopDebuggerOnAppExit " : true or "stopDebuggerOnAppExit " : false

If the key is specified with a value of "false", the "false" is ignored and the debugger still exits upon app shutdown.

The plugin should use the value of "stopDebuggerOnAppExit ", rather than the mere presence of the key.

TwitchBronBron commented 1 year ago

Are you using enableDebugProtocol: true? If so, then we have no way to keep the debugger active. Roku shuts it down on their end.

If not, then perhaps this is indeed a bug.

jimallison53 commented 1 year ago

Ah - no bug, then. Duh? Obviously haven't had enough coffee...

TwitchBronBron commented 1 year ago

Yeah we should probably update the description of that property to explain this better.