rokucommunity / roku-debug

A compatibility wrapper around the BrightScript debug protocol https://developer.roku.com/en-ca/docs/developer-program/debugging/socket-based-debugger.md
MIT License
13 stars 9 forks source link

Various improvements #22

Closed elsassph closed 3 years ago

elsassph commented 3 years ago

Tested both with a "vanilla" Roku project and a brighterscript-processed one.

TwitchBronBron commented 3 years ago

@elsassph you mention in this comment that "downstream expects 1-based". Where exactly is that the case? I don't recall doing 1-based translations in any of my sourcemap work last year, so I'd like to understand this a little better.

elsassph commented 3 years ago

@elsassph you mention in this comment that "downstream expects 1-based". Where exactly is that the case? I don't recall doing 1-based translations in any of my sourcemap work last year, so I'd like to understand this a little better.

Well that's a bit empirical. I'm not sure where the offset happens really :)