search

rokucommunity / roku-debug

A compatibility wrapper around the BrightScript debug protocol https://developer.roku.com/en-ca/docs/developer-program/debugging/socket-based-debugger.md
MIT License
13 stars 8 forks source link

compile errors are not reported #4

Closed georgejecook closed 2 years ago

georgejecook commented 4 years ago

When running my code on vscode extension 2.4.3, with all module's current to that release, I run my app with enableDebugProtocol true,

my project had compile errors (i.e. compile errors reported by the roku device not lsp); but I had no idea they were there; so I had to drop back to the legacy debugger. Then the compile errors were correctly reported console output, legacy debug

exitexitexitexitexitexitexitexitexitexit06-11 18:21:18.011 [beacon.signal] |AppLaunchInitiate ---------> TimeBase(0 ms)
06-11 18:21:18.012 [beacon.signal] |AppCompileInitiate --------> TimeBase(0 ms)
06-11 18:21:18.012 [scrpt.cmpl] Compiling '{{title}}', id 'dev'
06-11 18:21:18.071 [scrpt.load.mkup] Loading markup dev '{{title}}'
06-11 18:21:18.108 [scrpt.unload.mkup] Unloading markup dev '{{title}}'
06-11 18:21:18.203 [scrpt.parse.mkup.time] Parsed markup dev '{{title}}' in 132 milliseconds
------ Compiling dev '{{title}}' ------
*** ERROR compiling /pkg:/source/maestro/lib/Utils.brs:
Syntax Error. (compile error &h02) in pkg:/source/maestro/lib/Utils.brs(84)
Syntax Error. (compile error &h02) in pkg:/source/maestro/lib/Utils.brs(85)
Syntax Error. (compile error &h02) in pkg:/source/maestro/lib/Utils.brs(91)
Syntax Error. (compile error &h02) in pkg:/source/maestro/lib/Utils.brs(92)
Syntax Error. (compile error &h02) in pkg:/source/maestro/lib/Utils.brs(98)
=================================================================
An error occurred while attempting to compile the application's components:
-------> Compilation Failed.

console output debug socket debugger

1:22
Debug server mode has no output at all (in debug console) (edited) 
1:22
and in the output pane has
1:22
DebugServer: Moving selected files to staging area
DebugServer: Adding stop statements for active breakpoints
DebugServer: Creating zip archive from project sources
DebugServer: Connecting to Roku via the BrightScript debug protocol at 192.168.8.204
DebugServer: Exiting any active brightscript debugger
chrisdp commented 4 years ago

@georgejecook so I took your snippet and it is passing our tests so this tells me the issue is likely in how/when the event is being emitted. I'll try to keep an eye out on this as it's likely some sort of race condition.

chrisdp commented 2 years ago

Closing as this is issue is stale no longer valid.