search

rokucommunity / roku-deploy

An npm module for zipping and deploying to Roku devices.
MIT License
37 stars 16 forks source link

Overhaul the function parameters so they have only the options they need #123

Closed TwitchBronBron closed 7 months ago

TwitchBronBron commented 8 months ago

We currently allow the global roku-deploy options to just be passed around everywhere, which makes all the functions much more confusing because most of the time they don't need most of those options.

We need to create separate objects/interfaces for each function call, so it's clear how to use each one.

MilapNaik commented 7 months ago

In https://github.com/rokucommunity/roku-deploy/pull/126

TwitchBronBron commented 7 months ago

Closing in favor of https://github.com/rokucommunity/roku-deploy/issues/125