search

rokucommunity / ropm

A package manager for the Roku platform.
MIT License
31 stars 5 forks source link

Do not prefix bslib functions #25

Closed georgejecook closed 3 years ago

georgejecook commented 3 years ago

I tried to get a test to reproduce this; but it won't - it does it with ropm module maestro-view, (currenlty in my local) and applicaster. I added a spec to run against applicasster's code and verified this fixes it.

probs not what you want though; but hopefully this is enough to start a disucssion identify the problem.

georgejecook commented 3 years ago

oh.. and this doesn't solve the problem, coz we end up with duplciate functions.. I'll fix that presently

georgejecook commented 3 years ago

@TwitchBronBron this build is failing on some tests that I don't think have anything to do with my changes. as it stands I have to manually import the relevant bslib files all over the place, whenever I hit a crash, or simply not use template strings, ternary or any other language features in any ropm modules

TwitchBronBron commented 3 years ago

ropm isn't the place to fix this problem. I've been thinking about this recently, and we need to publish bslib as a ropm module, and add a flag in the brighterscript compiler that assumes bslib will be coming from ropm so it doesn't copy the bslib file on transpile.