rokucommunity / ropm

A package manager for the Roku platform.
MIT License
34 stars 6 forks source link

ropm is prefixing functions for a module where namespacing prefixing is disabled. #36

Open georgejecook opened 3 years ago

georgejecook commented 3 years ago

wanted to fix this, or at least give a test; but unfortunately I can't coz the latest has a bunch of errors I don't understand:

image

The issue is the following, whereby I have maestro module configured as such in packge.json:

  "ropm": {
    "rootDir": "src",
    "packageRootDir": "dist",
    "noprefix": [
      "maestro"
    ]
  },

The image shows that the function mxonFocusIdChange is not prefixed, however, references to it at the bottom of the file erronesouly have the `maestro` prefix added. I have to search/replace these for now, as otherwise applicaster cannot build anything. Sorry that I can't give a test; but I got latest and the build is broken, and I don't understand the compile error: so I don't know what to do there.

image

pawelhertman commented 3 years ago

My #46 PR fixes this issue