search

rokucommunity / ropm

A package manager for the Roku platform.
MIT License
31 stars 5 forks source link

Possibility to pass rootDir as Copy- and InstallCommand arg #40

Closed pawelhertman closed 3 years ago

pawelhertman commented 3 years ago

Hey, I'm working on a custom dependencies importer, and for files copying and prefixing I used this cool library. I don't use CLI but directly use CopyComand and found it unnecessarily limiting to have package.json as the only config possibility. IMO, ideally, these commands shouldn't be responsible for fetching config and aware of config placement - config should be passed as constructor argument or imported from a different entity. Anyway, I didn't want to rearrange your code so I decided to suggest the simplest, full-config-passing-ready solution

pawelhertman commented 3 years ago

@TwitchBronBron I updated the comment, sorry for delay. Please let me know if it's clear enough now.

pawelhertman commented 3 years ago

@TwitchBronBron PR synced with master

TwitchBronBron commented 3 years ago

This has been included in release 0.10.0