rokucommunity / ropm

A package manager for the Roku platform.
MIT License
31 stars 5 forks source link

Add support for workspace projects #67

Open slheavner opened 1 year ago

slheavner commented 1 year ago

npm ls for workspace projects include the "root" project, resulting in ropm including the workspace project as a dependency of itself, and adding postfixes (_v1, etc.) to its actual dependencies

How:

TwitchBronBron commented 1 year ago

One of the unit tests is failing in the CI, so can you take a look at that?

Also, does this change need to account for aliases (when we install some package with a different name)?

slheavner commented 1 year ago

One of the unit tests is failing in the CI, so can you take a look at that?

Also, does this change need to account for aliases (when we install some package with a different name)?

I think I got caught by mac's case-insensitive file system 🤦

The name comparison here doesn't touch the dependencies, it's only comparing the "host" package name to make sure it is used as the root dependency in the graph, so those aliases shouldn't apply

TwitchBronBron commented 1 year ago

Looks like it's still failing.

TwitchBronBron commented 6 months ago

oh wow, I completely forgot about this! I'll try and give it a good review this week. Sorry about that!

slheavner commented 6 months ago

no worries, revisiting.

There the problem with CI is the npm version tagged there vs what I was testing against. I need to dig into the differences and find what's causing it.

slheavner commented 6 months ago

workflow passed on my fork, should be good to go