Open slheavner opened 1 year ago
One of the unit tests is failing in the CI, so can you take a look at that?
Also, does this change need to account for aliases (when we install some package with a different name)?
One of the unit tests is failing in the CI, so can you take a look at that?
Also, does this change need to account for aliases (when we install some package with a different name)?
I think I got caught by mac's case-insensitive file system 🤦
The name comparison here doesn't touch the dependencies, it's only comparing the "host" package name to make sure it is used as the root dependency in the graph, so those aliases shouldn't apply
Looks like it's still failing.
oh wow, I completely forgot about this! I'll try and give it a good review this week. Sorry about that!
no worries, revisiting.
There the problem with CI is the npm version tagged there vs what I was testing against. I need to dig into the differences and find what's causing it.
workflow passed on my fork, should be good to go
npm ls
for workspace projects include the "root" project, resulting in ropm including the workspace project as a dependency of itself, and adding postfixes (_v1, etc.) to its actual dependenciesHow:
--json
fornpm ls
instead of--parseable
name
field