Closed georgejecook closed 5 years ago
I've made a lot of progress with this, and almost have a working implementation. Want to know if you're interested in it before I do more.. I'm stuck on one bug which is driving me nuts. I'll submit a WIP PR for you to see what I'm getting at, and where I'm stuck.. it makes it look like this for compile errors - I like it because then you can just click and go straight to the issue rather than rememebring what was in the dialog output. It's also inline, and strictly speaking, is a problem, too.
Here's a WIP branch which shows my experiments with this feature.. https://github.com/georgejecook/vscode-brightscript-language/commit/9a0c731b26d34686cc3b5fe219a5159b9941732a
If I were able to get unblocked on this line here, I could finish this feature by wednesday https://github.com/georgejecook/vscode-brightscript-language/commit/9a0c731b26d34686cc3b5fe219a5159b9941732a#diff-45327f86d4438556066de133327f4ca2R61
The thing holding me up is that the Uri is not working.. not sure why..
Yeah, definitely interested in this. Love the idea. I will take a look at it tomorrow if you haven't stayed up all night fixing it by then. 😉
WIP commit. Easier to see than my other branch, now that you merged all my other contributions down: https://github.com/TwitchBronBron/vscode-brightscript-language/pull/19
can you assign this to me @TwitchBronBron ? I've got a WIP PR which I'll add tests to this week.
This is resolved
Currently, we get a dialog box - it's not great to work with...
I tinkered with using diagnostics.. It would mean getting the list of compile errors, and updating the compile collection for each of the mentioned documents, as such: