rokucommunity / vscode-brightscript-language

A Visual Studio Code extension for Roku's BrightScript language
MIT License
110 stars 41 forks source link

Can no longer store launch configs in settings.json #227

Closed triwav closed 2 years ago

triwav commented 4 years ago

launch configs can not only be stored in launch.json but also in your user settings file. This is helpful so that if you open a folder in vscode you can still run it on your Roku without adding a launch.json locally. I believe it was in either beta 48 or 49 that this broke and now complains about uri being null I believe. This how it looks in the settings.json file:

 "launch": {
        // Use IntelliSense to learn about possible attributes.
        // Hover to view descriptions of existing attributes.
        // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
        "version": "0.2.0",

        "configurations": [{
                "type": "brightscript",
                "request": "launch",
                "name": "DEVICE PROMPT",
                "rootDir": "${workspaceFolder}",
                "host": "${promptForHost}",
                "password": "1234"
            }
        ]
    },

This goes at the base object level.

TwitchBronBron commented 2 years ago

@triwav do you think there's anything we can do on our end to mitigate this? Would you still like to see this featured fixed? Perhaps we could add a dedicated extension setting to allow you to define these in user settings instead?

triwav commented 2 years ago

@TwitchBronBron I believe this was already fixed. Not sure when though. I don't use it often but have run it a few times I believe

TwitchBronBron commented 2 years ago

Ok great. I'll close the ticket for now, and we can reopen in the future if we find it's still an issue.